Skip to content

drop port forwarding #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

drop port forwarding #6444

wants to merge 22 commits into from
+3,325 −526

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 13, 2025 •
edited
Loading

  • include a proxy endpoint that routes traffic to the node-server
  • reduce frontend nextjs image size to ~300MB

I'm hoping this supplements #6204

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@netlify
Copy link

netlify bot commented Oct 13, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit 638be0e
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68f111b83e6acf0008b98e4e
😎 Deploy Preview https://deploy-preview-6444--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2025
@dprotaso dprotaso mentioned this pull request Oct 13, 2025
Closed
dprotaso added 15 commits October 14, 2025 10:44
@dprotaso
include a proxy endpoint that routes traffic to the node-server
404cb9f 
this simplifies client interaction as we don't require port-fowarding anymore
@dprotaso
reduce frontend nextjs image size to ~300MB
4389e55
@dprotaso
use port 80 for frontend k8s service
1610987
@dprotaso
include node about checking the tunnels for connectivity
adb4222
@dprotaso
fix non-websocket backend requests
6531767
@dprotaso
sync frontend solution with changes
f252b0a
@dprotaso
Minor tweaks to section 2
238bee0
@dprotaso
fix setup.sh script and update solution.sh script
0a1f21f
@dprotaso
remove actual webhook url from docs
8386925
@dprotaso
fix ports on env setup since we're not using localhost anymore
ec7f62a
@dprotaso
when creating the function include the type so invocation works
c060a07
@dprotaso
fix indentation and kubectl log line
fefea9f
@dprotaso
don't use localhost anymore to access the frontend website
8b33791
@dprotaso
fix indentation on page 7
5886693
@dprotaso
quote the camel-k installation so it works on zsh
fe2efe6
@dprotaso dprotaso force-pushed the drop-port-forwarding branch from 52b1140 to fe2efe6 Compare October 14, 2025 14:44
@dprotaso dprotaso marked this pull request as ready for review October 14, 2025 14:44
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@knative-prow knative-prow bot requested review from nainaz and skonto October 14, 2025 14:44
@dprotaso dprotaso closed this Oct 14, 2025
@dprotaso dprotaso reopened this Oct 14, 2025
@dprotaso
Copy link
Member Author

re-opened so we get the github rate limit fix in main

Leo6Leo
Leo6Leo reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished it yet. Submitting for the first round of review.

Leo6Leo
Leo6Leo reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished most of the review, beside these comments, the rest looks good. I will be manually follow and run through the tutorial later to make sure content is accurate. Thanks @dprotaso !

code-samples/eventing/bookstore-sample-app/solution/solution.sh

# Install Camel-K
echo ""
echo "📦 Installing Camel-K..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like $REGISTRY_PORT value cannot be empty here. If it is, the script will exit with error.

error: error parsing STDIN: error converting YAML to JSON: yaml: line 9: mapping values are not allowed in this context

I haven't used the local registry yet, so couldn't comment on this too much. Originally in the old version of tutorial, the remote registry address is requested.

https://github.com/dprotaso/knative-docs/blob/1ec7a2b8807bd23fcf3c217e0adc5634b5e2d0bf/code-samples/eventing/bookstore-sample-app/solution/solution.sh#L63-L75

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these variables are read in line 62/63

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as github doesn't allow me to comment on that line 😅

Also, since now we are officially recommend users to use KinD, the port and registry could have a default value.

"🔑 Enter the registry port:" can be updated to "🔑 Enter the registry port (e.g. 5001 for KinD local registry):"

@dprotaso
Copy link
Member Author

bump @Leo6Leo

@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 23, 2025 •
edited
Loading

https://github.com/dprotaso/knative-docs/blob/drop-port-forwarding/code-samples/eventing/bookstore-sample-app/solution/ML-bad-word-filter/func.yaml#L6

The registry route should be updated to dynamic, and use the one that's being provided by the user input.

Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

Leo6Leo
Leo6Leo suggested changes Oct 23, 2025
View reviewed changes
code-samples/eventing/bookstore-sample-app/solution/solution.sh

# Install Camel-K
echo ""
echo "📦 Installing Camel-K..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as github doesn't allow me to comment on that line 😅

Also, since now we are officially recommend users to use KinD, the port and registry could have a default value.

"🔑 Enter the registry port:" can be updated to "🔑 Enter the registry port (e.g. 5001 for KinD local registry):"

@dprotaso
Copy link
Member Author

The registry route should be updated to dynamic, and use the one that's being provided by the user input.
Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

Want do make those changes in a follow up?

@Leo6Leo Leo6Leo mentioned this pull request Oct 24, 2025
Open
@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 24, 2025

@dprotaso #6471

The follow up issue has been created. Another review will be needed after the func issue being fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmejia02 mmejia02 Awaiting requested review from mmejia02

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

@nainaz nainaz Awaiting requested review from nainaz

@skonto skonto Awaiting requested review from skonto

1 more reviewer

@Leo6Leo Leo6Leo Leo6Leo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Leo6Leo Leo6Leo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprotaso @Leo6Leo